Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/lw 12074 enable new input resolver in lace #1639

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Feat/lw 12074 enable new input resolver in lace #1639

merged 4 commits into from
Jan 14, 2025

Conversation

AngelCastilloB
Copy link
Member

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Enable new Input resolver on Lace

Proposed solution

Add a new feature flag to toggle blockfrost input resolver on Lace

@AngelCastilloB AngelCastilloB requested a review from a team as a code owner January 10, 2025 12:47
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-12074-enable-new-input-resolver-in-lace branch 4 times, most recently from 5ae6f1b to aafe57d Compare January 10, 2025 13:17
@pczeglik-iohk
Copy link
Contributor

pczeglik-iohk commented Jan 10, 2025 •
edited
Loading

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for 921f7272

passed failed skipped flaky total result
Total 33 0 4 0 37 ✅

@AngelCastilloB AngelCastilloB marked this pull request as draft January 10, 2025 13:47
@AngelCastilloB AngelCastilloB force-pushed the feat/lw-12074-enable-new-input-resolver-in-lace branch from df20d8d to c5eef30 Compare January 14, 2025 02:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AngelCastilloB AngelCastilloB marked this pull request as ready for review January 14, 2025 04:13
mkazlauskas
mkazlauskas approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@mkazlauskas mkazlauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@AngelCastilloB AngelCastilloB merged commit 3ba4110 into main Jan 14, 2025
58 of 59 checks passed
@AngelCastilloB AngelCastilloB deleted the feat/lw-12074-enable-new-input-resolver-in-lace branch January 14, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkazlauskas mkazlauskas mkazlauskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AngelCastilloB @pczeglik-iohk @mkazlauskas